I just noticed that download counters for files (funscript, srt, etc) is not shown anymore.
It’s still shown for the external links, though.
@VladTheImplier
Is that a new change/bug on Discord? A site setting?
1 Like
I don’t think this is a change. This has always been discourse behavior.
The counter isn’t a download counter. It’s a link clicking counter and internal links don’t typically get the counters.
See this example on the meta: Attachment "number of downloads" counter resets whenever a reply is edited - #16 by codinghorror - Bug - Discourse Meta
I definitely remember seeing these numbers before on my own uploads. They showed counts across all my posts and recently disappeared from all of them at once, without any edits. Was there a site update or something recently that wiped them?
There was a site update, but I personally don’t recall this behavior being a thing. Does anyone have an archive link or a historical screenshot?
I’m trying to find a screenshot, but I can’t find one. It looked exactly like the counter on links. But I’m sure it was a thing. This is something I relied on for many years. The counter disappeared in the last 3-4 weeks.
Old topic about how to show those counters for funscript (i.e. remove the attachement flag):
quick test upload
test.txt (15 Bytes)
I’m able ‘simulate’ the look by adding a ‘data-clicks’ argument to the element (i.e. the external links have that argument).
Manually edited html:
I’ll search in discourse sources about that ‘data-clicks’ field.
testing on the redis cache/console if there was a change, it’s probably the behavior of attachment links changed behavior.
I’m doubtful I can do anything beyond this point.
Thought it has always been this way. I have been manually removing “attachment” from the string to make it render as a link, so that there can be a counter next to it.
1 Like
I’m reviewing the code from the commit that supposedly implemented the counters and the commit that I believe would be responsible for breaking it.
This functionality was completely re-written between so it’s likely bad quality control on the part of discourse, which would not surprise me, or it was always like this and the attachment hack stopped working.
3 Likes
I do know what op is talking about I haven’t seen any counters recently
Yes, that needed to be necessary to show the counter, but that no longer works.
For example here I could see the number of download (or, to be pedantic, the number of clicks) for each file previously because I had removed the |attachment part in the links:
And now like Zalunda mentions it only shows the counters for links to sites.
Since it’s confirmed the issue I’ll see if we can fix it.
3 Likes
I’d like to add that I never removed |attachment from my uploads and I still saw the counter, until just recently.
2 Likes
Same for my uploads as well
1 Like
I recently was reached out about an api problem.
I think since the last update discourse treats some uploads differently than before.
The API even doesn’t return the same information that it used to. Uploads are no longer part of links.
Still digging into this.
4 Likes